[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/11] target/hppa: fix overwriting source reg in ad
From: |
Sven Schnelle |
Subject: |
[Qemu-devel] [PATCH 01/11] target/hppa: fix overwriting source reg in addb |
Date: |
Mon, 11 Mar 2019 20:15:52 +0100 |
When one of the source registers is the same as the destination register,
the source register gets overwritten with the destionation value before
do_add_sv() is called, which leads to unexpection condition matches.
Signed-off-by: Sven Schnelle <address@hidden>
---
target/hppa/translate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index dc5636fe94..7001c2eb80 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -3033,7 +3033,7 @@ static bool do_addb(DisasContext *ctx, unsigned r,
TCGv_reg in1,
DisasCond cond;
in2 = load_gpr(ctx, r);
- dest = dest_gpr(ctx, r);
+ dest = tcg_temp_new();
sv = NULL;
cb_msb = NULL;
@@ -3049,6 +3049,8 @@ static bool do_addb(DisasContext *ctx, unsigned r,
TCGv_reg in1,
}
cond = do_cond(c * 2 + f, dest, cb_msb, sv);
+ save_gpr(ctx, r, dest);
+ tcg_temp_free(dest);
return do_cbranch(ctx, disp, n, &cond);
}
--
2.20.1
- [Qemu-devel] [PATCH 09/11] target/hppa: add TLB protection id check, (continued)
- [Qemu-devel] [PATCH 09/11] target/hppa: add TLB protection id check, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 06/11] target/hppa: ignore DIAG opcode, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 10/11] target/hppa: exit TB if either Data or Instruction TLB changes, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 07/11] target/hppa: fix b,gate instruction, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 05/11] target/hppa: remove PSW I/R/Q bit check, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 01/11] target/hppa: fix overwriting source reg in addb,
Sven Schnelle <=
- [Qemu-devel] [PATCH 02/11] target/hppa: fix TLB handling for page 0, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 03/11] target/hppa: report ITLB_EXCP_MISS for ITLB misses, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 04/11] target/hppa: add TLB trace events, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 08/11] target/hppa: allow multiple itlbp without itlba, Sven Schnelle, 2019/03/11
- Re: [Qemu-devel] [PATCH 00/11] target/hppa patches, no-reply, 2019/03/11