[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 7/10] qemu-binfmt-conf.sh: generalize CPU to
From: |
Unai Martinez Corral |
Subject: |
Re: [Qemu-devel] [PATCH v4 7/10] qemu-binfmt-conf.sh: generalize CPU to positional TARGETS |
Date: |
Mon, 11 Mar 2019 14:29:38 +0100 |
2019/3/11 12:14, Laurent Vivier:
> On 11/03/2019 11:30, Unai Martinez-Corral wrote:
> > + if [ "$unknown_target" = "true" ] ; then
>
> if [ "x$cpu" != "x$target" ] ; then
My bad. I fixed it before squashing, and broke it again when doing it.
> > +-s|--systemd: don't write into /proc, generate
> > file(s) for
> > + systemd-binfmt.service; environment
> > variable HOST_ARCH
>
> why HOST_ARCH appears here?
The existing comment seems to be specific to systemd:
https://github.com/qemu/qemu/blob/master/scripts/qemu-binfmt-conf.sh#L201-L204
'systemd' is the single mode in which it makes sense to generate a
bunch of configuration files for a different architecture than the
current one, isn't it?
Regards,
Unai
- Re: [Qemu-devel] [PATCH v4 3/10] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT, (continued)
- [Qemu-devel] [PATCH v4 2/10] qemu-binfmt-conf.sh: make opts -p and -c boolean, Unai Martinez-Corral, 2019/03/11
- [Qemu-devel] [PATCH v4 4/10] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*, Unai Martinez-Corral, 2019/03/11
- [Qemu-devel] [PATCH v4 1/10] qemu-binfmt-conf.sh: enforce safe style consistency, Unai Martinez-Corral, 2019/03/11
- [Qemu-devel] [PATCH v4 5/10] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options, Unai Martinez-Corral, 2019/03/11
- [Qemu-devel] [PATCH v4 6/10] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX, Unai Martinez-Corral, 2019/03/11
- [Qemu-devel] [PATCH v4 7/10] qemu-binfmt-conf.sh: generalize CPU to positional TARGETS, Unai Martinez-Corral, 2019/03/11
[Qemu-devel] [PATCH v4 8/10] qemu-binfmt-conf.sh: add option --clear, Unai Martinez-Corral, 2019/03/11
[Qemu-devel] [PATCH v4 9/10] qemu-binfmt-conf.sh: update usage(), Unai Martinez-Corral, 2019/03/11
[Qemu-devel] [PATCH v4 10/10] qemu-binfmt-conf.sh: add --test|--dry-run, Unai Martinez-Corral, 2019/03/11