Re: [Qemu-devel] [PATCH v2 0/4] memfd fixes.

[Marc-André Lureau]

Hi

On Mon, Mar 11, 2019 at 1:35 PM Ilya Maximets <address@hidden> wrote:
>
> Hi.
>
> I'm trying to figure out the state of this patch set.
> Is there any chance for it to be accepted?
>
> The first patch needs minor rebase. I could send a new version.

Please do,

I prefer the solution proposed in v2: do not register hostmem-memfd if
sealing isn't supported (keep sealing=true the default - it's one of
the main purpose of memfd imho).

Daniel, Eduardo: are you ok with this series for 4.0?

>
> BTW, even without the first patch that raised some discussion
> the last three patches are kind of straightforward and useful.
>
> Best regards, Ilya Maximets.
>
> On 27.11.2018 16:50, Ilya Maximets wrote:
> > Version 2:
> >     * First patch changed to just drop the memfd backend
> >       if seals are not supported.
> >
> > Ilya Maximets (4):
> >   hostmem-memfd: disable for systems wihtout sealing support
> >   memfd: always check for MFD_CLOEXEC
> >   memfd: set up correct errno if not supported
> >   memfd: improve error messages
> >
> >  backends/hostmem-memfd.c | 18 ++++++++----------
> >  tests/vhost-user-test.c  |  6 +++---
> >  util/memfd.c             | 10 ++++++++--
> >  3 files changed, 19 insertions(+), 15 deletions(-)
> >
>


-- 
Marc-André Lureau