[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: fix small leak
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH] migration: fix small leak |
|
Date: |
Mon, 11 Mar 2019 10:57:05 +0800 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Mar 08, 2019 at 05:07:31PM +0100, Marc-André Lureau wrote:
[...]
> diff --git a/migration/socket.c b/migration/socket.c
> index 239527fb1f..49bacf78fd 100644
> --- a/migration/socket.c
> +++ b/migration/socket.c
> @@ -199,6 +199,7 @@ static void socket_start_incoming_migration(SocketAddress
> *saddr,
> return;
> }
> migrate_add_address(address);
> + qapi_free_SocketAddress(address);
Or just don't clone in migrate_add_address()? Either way:
Reviewed-by: Peter Xu <address@hidden>
Regards,
--
Peter Xu