[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak |
|
Date: |
Sun, 10 Mar 2019 15:34:08 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/10/19 12:34 PM, Li Qiang wrote:
> Fixes: 2dbfadf
^ Please keep tags together (with Signed-off-by, ...)
> Spotted by ASAN when 'make check'.
I'm not native English speaker but I'd say:
Spotted by ASAN [with] 'make check'.
or
Spotted by ASAN [while running] 'make check'.
Here goes:
"Fixes: 2dbfadf"
> Signed-off-by: Li Qiang <address@hidden>
> ---
> tests/test-bdrv-graph-mod.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c
> index 458dfa6661..8bf0fe735d 100644
> --- a/tests/test-bdrv-graph-mod.c
> +++ b/tests/test-bdrv-graph-mod.c
> @@ -117,6 +117,7 @@ static void test_update_perm_tree(void)
>
> bdrv_unref(bs);
> blk_unref(root);
> + error_free(local_err);
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> }
>
> /*
>