Re: [Qemu-devel] [qemu-s390x] [PATCH v3 08/16] s390-bios: Map low core memory

[Cornelia Huck]

On Wed, 6 Mar 2019 14:28:42 -0500
"Jason J. Herne" <address@hidden> wrote:

> On 3/5/19 1:27 AM, Thomas Huth wrote:
> > On 01/03/2019 19.59, Jason J. Herne wrote:  

> >> +    PSW             return_psw;               /* 0x200 */
> >> +    uint8_t         irb[64];                  /* 0x210 */
> >> +    uint64_t        sync_enter_timer;         /* 0x250 */
> >> +    uint64_t        async_enter_timer;        /* 0x258 */
> >> +    uint64_t        exit_timer;               /* 0x260 */
> >> +    uint64_t        last_update_timer;        /* 0x268 */
> >> +    uint64_t        user_timer;               /* 0x270 */
> >> +    uint64_t        system_timer;             /* 0x278 */
> >> +    uint64_t        last_update_clock;        /* 0x280 */
> >> +    uint64_t        steal_clock;              /* 0x288 */
> >> +    PSW             return_mcck_psw;          /* 0x290 */  
> > 
> > ... but where do these entries between 0x200 and 0x2a0 come from? They
> > do not seem to be defined by the Principles of Operation?
> >   
> 
> Taken from target/s390x/internal.h. I stopped at "/* System info area */". 
> Now that I'm 
> looking at it, I'm not sue where these are coming from.... I will remove them 
> in the next 
> version.

That was coming from an very old version of the lowcore in the Linux
kernel... removed from internal.h with a patch queued on s390-next
now :)