[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 3/3] usb-mtp: prevent null dereference while dele
From: |
Bandan Das |
Subject: |
[Qemu-devel] [PATCH v2 3/3] usb-mtp: prevent null dereference while deleting objects |
Date: |
Wed, 6 Mar 2019 16:04:09 -0500 |
Spotted by Coverity: CID 1399144
Signed-off-by: Bandan Das <address@hidden>
---
hw/usb/dev-mtp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 1f22284949..06e376bcd2 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -1177,9 +1177,7 @@ static int usb_mtp_deletefn(MTPState *s, MTPObject *o,
uint32_t trans)
usb_mtp_object_free_one(s, o);
success = true;
}
- }
-
- if (o->format == FMT_ASSOCIATION) {
+ } else if (o->format == FMT_ASSOCIATION) {
if (rmdir(o->path)) {
partial_delete = true;
} else {
--
2.19.2