[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with pers
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with persistent bitmaps |
Date: |
Wed, 6 Mar 2019 09:36:09 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/6/19 9:33 AM, Vladimir Sementsov-Ogievskiy wrote:
>> + /* Flush bitmaps */
>> + if (s->nb_bitmaps) {
>> + Error *local_err = NULL;
>> +
>> + /* Usually, bitmaps get resized after this call.
>> + * Force it earlier so we can make the metadata consistent. */
>> + bdrv_dirty_bitmap_truncate(bs, offset);
>> + qcow2_flush_persistent_dirty_bitmaps(bs, &local_err);
>> + if (local_err) {
>> + ret = -EINVAL;
>> + goto fail;
>> + }
>> + }
>
> Why to flush after resize? Bitmaps will be IN_USE in the image anyway...
>
> Could we implement resize without flush first, it would be one patch + test?
> And then consider
> flushing in separate?
What happens with migration if we don't flush the new size to disk, so
the on-disk format has a different size than the in-memory version?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/5] block/qcow2-bitmap: Allow bitmap flushing, (continued)
[Qemu-devel] [PATCH 1/5] block/qcow2-bitmap: Skip length check in some cases, John Snow, 2019/03/05
[Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with persistent bitmaps, John Snow, 2019/03/05
- Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with persistent bitmaps, Vladimir Sementsov-Ogievskiy, 2019/03/06
- Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with persistent bitmaps, John Snow, 2019/03/06
- Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with persistent bitmaps, Vladimir Sementsov-Ogievskiy, 2019/03/06
- Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with persistent bitmaps, Vladimir Sementsov-Ogievskiy, 2019/03/06
- Re: [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Allow resizes with persistent bitmaps, John Snow, 2019/03/08
[Qemu-devel] [PATCH 5/5] tests/qemu-iotests: add bitmap resize test 246, John Snow, 2019/03/05
Re: [Qemu-devel] [PATCH 0/5] block/qcow2-bitmap: Enable resize with persistent bitmaps, John Snow, 2019/03/05
Re: [Qemu-devel] [PATCH 0/5] block/qcow2-bitmap: Enable resize with persistent bitmaps, no-reply, 2019/03/10
Re: [Qemu-devel] [PATCH 0/5] block/qcow2-bitmap: Enable resize with persistent bitmaps, Eric Blake, 2019/03/11