[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vhost-user-test: fix leaks
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] vhost-user-test: fix leaks |
|
Date: |
Wed, 6 Mar 2019 10:28:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/5/19 11:51 PM, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/vhost-user-test.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 4cd0a97f13..9364227ba4 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -588,6 +588,7 @@ static void test_server_free(TestServer *server)
> g_test_message("unable to rmdir: path (%s): %s",
> server->tmpfs, strerror(errno));
> }
> + g_free(server->tmpfs);
Fixes: ae31fb54914 and 4d3f50eb489
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
> qemu_chr_fe_deinit(&server->chr, true);
>
> @@ -605,6 +606,8 @@ static void test_server_free(TestServer *server)
>
> g_main_loop_unref(server->loop);
> g_main_context_unref(server->context);
> + g_cond_clear(&server->data_cond);
> + g_mutex_clear(&server->data_mutex);
> g_free(server);
> }
>
>