Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add CPUS, add --reset, make -p and -c boolean (no arg)

[Eric Blake]

On 3/5/19 1:36 PM, Unai Martinez Corral wrote:
> 2019/3/5 17:57, Eric Blake:
> > You are correct that 'printf -1' is likely to fail, 'printf -- -1' is
> > portable but unusual, and 'printf %s\\n -1' is identical to the common
> > (but non-portable) behavior of 'echo -1'. Is the newline important?
>
> In this case, the newline seems not to be relevant. I find 'printf --
> -1' elegant, but since I already submitted v2 of the patch, I think
> the difference compared to 'printf %s -1' is not worth a new version.
> Please, let me know if you feel otherwise.

I don't have a strong preference between the two forms - so this is your 
chance to assert your creative liberty. But I don't know enough about 
binfmt_misc to know if the newline matters. I'm just reviewing on the 
basis of shell portability, and hope that other reviewers more familiar 
with binfmt will review on content. That said, I already have enough 
other comments on v2 that you may want to split this into a series of 
patches for v3, although you could also wait a day or so to see if 
anyone else reviews and minimize the list churn.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org