[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] pflash_cfi01: Add pflash_cfi01_get_blk() he
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] pflash_cfi01: Add pflash_cfi01_get_blk() helper |
Date: |
Tue, 5 Mar 2019 18:17:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 03/04/19 20:48, Philippe Mathieu-Daudé wrote:
> Add an helper to access the opaque struct PFlashCFI01.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> [PMD: Extracted from bigger patch]
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/block/pflash_cfi01.c | 5 +++++
> include/hw/block/flash.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
> index 9d1c356eb6..9ecab693e8 100644
> --- a/hw/block/pflash_cfi01.c
> +++ b/hw/block/pflash_cfi01.c
> @@ -972,6 +972,11 @@ MemoryRegion *pflash_cfi01_get_memory(PFlashCFI01 *fl)
> return &fl->mem;
> }
>
> +BlockBackend *pflash_cfi01_get_blk(PFlashCFI01 *fl)
> +{
> + return fl->blk;
> +}
> +
> static void postload_update_cb(void *opaque, int running, RunState state)
> {
> PFlashCFI01 *pfl = opaque;
> diff --git a/include/hw/block/flash.h b/include/hw/block/flash.h
> index 914932eaec..a0f488732a 100644
> --- a/include/hw/block/flash.h
> +++ b/include/hw/block/flash.h
> @@ -22,6 +22,7 @@ PFlashCFI01 *pflash_cfi01_register(hwaddr base,
> uint16_t id0, uint16_t id1,
> uint16_t id2, uint16_t id3,
> int be);
> +BlockBackend *pflash_cfi01_get_blk(PFlashCFI01 *fl);
> MemoryRegion *pflash_cfi01_get_memory(PFlashCFI01 *fl);
>
> /* pflash_cfi02.c */
>
I generally prefer to keep the same order between declarations of
functions, and definitions of the same functions. Compare
pflash_cfi01_get_memory() here.
With that updated,
Reviewed-by: Laszlo Ersek <address@hidden>
Thanks
Laszlo
- [Qemu-devel] [RFC PATCH 0/4] pc: Support firmware configuration with -blockdev (splitted), Philippe Mathieu-Daudé, 2019/03/04
- [Qemu-devel] [PATCH 1/4] pflash_cfi01: Add pflash_cfi01_get_blk() helper, Philippe Mathieu-Daudé, 2019/03/04
- Re: [Qemu-devel] [PATCH 1/4] pflash_cfi01: Add pflash_cfi01_get_blk() helper,
Laszlo Ersek <=
- [Qemu-devel] [PATCH 2/4] hw/i386/pc_sysfw: Remove obsolete PcSysFwDevice, Philippe Mathieu-Daudé, 2019/03/04
- [Qemu-devel] [PATCH 3/4] hw/i386/pc_sysfw: Let pc_system_firmware_init() access PCMachineState, Philippe Mathieu-Daudé, 2019/03/04
- [Qemu-devel] [RFC PATCH 4/4] pc: Support firmware configuration with -blockdev, Philippe Mathieu-Daudé, 2019/03/04
- Re: [Qemu-devel] [RFC PATCH 0/4] pc: Support firmware configuration with -blockdev (splitted), Markus Armbruster, 2019/03/06