Re: [Qemu-devel] [PULL 00/73] tcg: per-cpu locks

[Peter Maydell]

On Tue, 5 Mar 2019 at 15:01, Richard Henderson
<address@hidden> wrote:
>
> This is Emilio's v7, unchanged, so I'm not re-posting the 73 patches.
>
> I also didn't want to add Signed-off-by to 73 patches, so I verified
> that there was nothing on Emilio's branch that shouldn't be there and
> then used git-merge -S --signoff.

Hi; I'm afraid this doesn't build on OSX:

/Users/pm215/src/qemu-for-merges/target/i386/hvf/x86hvf.c:361:14:
error: unused variable 'interrupt_request' [-Werror,-Wunused-variable]
    uint32_t interrupt_request;
             ^
/Users/pm215/src/qemu-for-merges/target/i386/hvf/x86hvf.c:465:23:
error: incompatible pointer types passing 'X86CPU *' (aka 'struct
X86CPU *') to parameter of type 'CPUState *' (aka 'struct CPUState *')
[-Werror,-Wincompatible-pointer-types]
    return cpu_halted(cpu);
                      ^~~
/Users/pm215/src/qemu-for-merges/include/qom/cpu.h:510:45: note:
passing argument to parameter 'cpu' here
static inline uint32_t cpu_halted(CPUState *cpu)
                                            ^
2 errors generated.


thanks
-- PMM