Re: [Qemu-devel] [PATCH v1 1/3] intel_iommu: scalable mode emulation

[Peter Xu]

On Tue, Mar 05, 2019 at 10:34:53AM +0800, Yi Sun wrote:
> From: "Liu, Yi L" <address@hidden>
> 
> Intel(R) VT-d 3.0 spec introduces scalable mode address translation to
> replace extended context mode. This patch extends current emulator to
> support Scalable Mode which includes root table, context table and new
> pasid table format change. Now intel_iommu emulates both legacy mode
> and scalable mode (with legacy-equivalent capability set).
> 
> The key points are below:
> 1. Extend root table operations to support both legacy mode and scalable
>    mode.
> 2. Extend context table operations to support both legacy mode and
>    scalable mode.
> 3. Add pasid tabled operations to support scalable mode.
> 
> Signed-off-by: Liu, Yi L <address@hidden>
> [Yi Sun is co-developer to contribute much to refine the whole commit.]
> Signed-off-by: Yi Sun <address@hidden>
> ---
> RFC v2->v1
>     - revert unnecessary rename in 'vtd_ce_present".
>     - use 'ce_size' to judge if it is scalable mode in
>       'vtd_get_context_entry_from_root'.
>     - remove some 'inline' declarations.
>     - remove unnecessary scalable mode check in 'vtd_ce_type_check' and
>       make corresponding changes in 'vtd_dev_to_context_entry'.
>     - add 'VTD_FR_PASID_TABLE_INV' case in 'vtd_qualified_faults[]'.
>     - create a macro function to handle a repeated pattern about 'is_fpd_set'.
>     - explicitly print 'legacy mode' when calling 'trace_vtd_replay_ce_valid'.

Reviewed-by: Peter Xu <address@hidden>

-- 
Peter Xu