Re: [Qemu-devel] [PATCH v2] isa/piix: move to mips malta

[Philippe Mathieu-Daudé]

Hi Michael,

On 1/9/18 3:59 PM, Michael S. Tsirkin wrote:
> This device is only used on mips malta, move it to the maintainer
> that's actually testing it.

Slighly related to this patch, since I included it while working on
Kconfig/MIPS.
I splitted PIIX3/PIIX4 (Actually PIIX3 was mixed with I440FX).
These are indeed 2 different chipsets, PIIX4 is an improved PIIX3.

I compiled MIPS with PIIX4 and it works, however when I ran all the
testsuite X86 failed due to PIIX4_PM missing.
I looked where it is used:

$ git grep PIIX4_PM
docs/interop/firmware.json:96:#           enabled with "-global
PIIX4_PM.disable_s3=0" and disabled
docs/interop/firmware.json:97:#           with "-global
PIIX4_PM.disable_s3=1". On the "pc-q35-*"
docs/interop/firmware.json:105:#           can be enabled with "-global
PIIX4_PM.disable_s4=0" and
docs/interop/firmware.json:106:#           disabled with "-global
PIIX4_PM.disable_s4=1". On the
hw/i386/pc.c:282:    { "PIIX4_PM", "memory-hotplug-support", "off" },
hw/i386/pc.c:299:    { "PIIX4_PM",
"acpi-pci-hotplug-with-bridge-support", "off" },

So now I'm confused, looking at git history I see you introduced this in
commit 9e047b98245.

What chipset do use the PC machine? An unreal hybrid of PIIX3/PIIX4?

Thanks,

Phil.

> 
> Cc: Aurelien Jarno <address@hidden>
> Cc: Yongbok Kim <address@hidden>
> Cc: Hervé Poussineau <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> 
> Aurelien, pls feel free to merge this or v1.
> 
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0255113..0b8a5e7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -641,6 +641,7 @@ Malta
>  M: Aurelien Jarno <address@hidden>
>  S: Maintained
>  F: hw/mips/mips_malta.c
> +F: hw/isa/piix4.c
>  
>  Mipssim
>  M: Yongbok Kim <address@hidden>
> @@ -849,7 +850,6 @@ F: hw/pci-host/q35.c
>  F: hw/pci-host/pam.c
>  F: include/hw/pci-host/q35.h
>  F: include/hw/pci-host/pam.h
> -F: hw/isa/piix4.c
>  F: hw/isa/lpc_ich9.c
>  F: hw/i2c/smbus_ich9.c
>  F: hw/acpi/piix4.c
>