Re: [Qemu-devel] [PATCH 1/5] lsi: use ldn_le_p()/stn_le_p()

[Eric Blake]

On 3/4/19 2:38 PM, Sven Schnelle wrote:
> Hi Eric,
>
> On Mon, Mar 04, 2019 at 12:40:50PM -0600, Eric Blake wrote:
> > On 3/4/19 12:09 PM, Sven Schnelle wrote:
> > > Signed-off-by: Sven Schnelle <address@hidden>
> >
> > The commit header says "what" (good), but the commit body says nothing at
> > all (generally, it should say "why"). If you give your reviewers a reason
> > why it is good to use the new functions, it makes it easier to apply your
> > patch.
> >
> > Also, don't forget to send a 0/5 cover letter when sending a patch series;
> > you can have git do this for you with 'git config format.coverletter auto'.
> > https://wiki.qemu.org/Contribute/SubmitAPatch has more hints for improved
> > patch handling.
>
> Thanks, will keep this in mind, sorry. Should i resend the series?

Up to you, but if it were me, I'd probably wait a day or two for any 
other review comments to address those at the same time, or for a 
definitive answer from the particular maintainer that will be including 
your patches.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org