[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 38/73] arm: convert to cpu_interrupt_request
From: |
Emilio G. Cota |
Subject: |
[Qemu-devel] [PATCH v7 38/73] arm: convert to cpu_interrupt_request |
Date: |
Mon, 4 Mar 2019 13:17:38 -0500 |
Cc: Peter Maydell <address@hidden>
Cc: address@hidden
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
---
target/arm/cpu.c | 6 +++---
target/arm/helper.c | 16 +++++++---------
target/arm/machine.c | 2 +-
3 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 845730c00c..7037e22580 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -73,7 +73,7 @@ static bool arm_cpu_has_work(CPUState *cs)
ARMCPU *cpu = ARM_CPU(cs);
return (cpu->power_state != PSCI_OFF)
- && cs->interrupt_request &
+ && cpu_interrupt_request(cs) &
(CPU_INTERRUPT_FIQ | CPU_INTERRUPT_HARD
| CPU_INTERRUPT_VFIQ | CPU_INTERRUPT_VIRQ
| CPU_INTERRUPT_EXITTB);
@@ -484,7 +484,7 @@ void arm_cpu_update_virq(ARMCPU *cpu)
bool new_state = (env->cp15.hcr_el2 & HCR_VI) ||
(env->irq_line_state & CPU_INTERRUPT_VIRQ);
- if (new_state != ((cs->interrupt_request & CPU_INTERRUPT_VIRQ) != 0)) {
+ if (new_state != ((cpu_interrupt_request(cs) & CPU_INTERRUPT_VIRQ) != 0)) {
if (new_state) {
cpu_interrupt(cs, CPU_INTERRUPT_VIRQ);
} else {
@@ -505,7 +505,7 @@ void arm_cpu_update_vfiq(ARMCPU *cpu)
bool new_state = (env->cp15.hcr_el2 & HCR_VF) ||
(env->irq_line_state & CPU_INTERRUPT_VFIQ);
- if (new_state != ((cs->interrupt_request & CPU_INTERRUPT_VFIQ) != 0)) {
+ if (new_state != ((cpu_interrupt_request(cs) & CPU_INTERRUPT_VFIQ) != 0)) {
if (new_state) {
cpu_interrupt(cs, CPU_INTERRUPT_VFIQ);
} else {
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 1fa282a7fc..2affe7965c 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -1893,23 +1893,24 @@ static uint64_t isr_read(CPUARMState *env, const
ARMCPRegInfo *ri)
CPUState *cs = ENV_GET_CPU(env);
uint64_t hcr_el2 = arm_hcr_el2_eff(env);
uint64_t ret = 0;
+ uint32_t interrupt_request = cpu_interrupt_request(cs);
if (hcr_el2 & HCR_IMO) {
- if (cs->interrupt_request & CPU_INTERRUPT_VIRQ) {
+ if (interrupt_request & CPU_INTERRUPT_VIRQ) {
ret |= CPSR_I;
}
} else {
- if (cs->interrupt_request & CPU_INTERRUPT_HARD) {
+ if (interrupt_request & CPU_INTERRUPT_HARD) {
ret |= CPSR_I;
}
}
if (hcr_el2 & HCR_FMO) {
- if (cs->interrupt_request & CPU_INTERRUPT_VFIQ) {
+ if (interrupt_request & CPU_INTERRUPT_VFIQ) {
ret |= CPSR_F;
}
} else {
- if (cs->interrupt_request & CPU_INTERRUPT_FIQ) {
+ if (interrupt_request & CPU_INTERRUPT_FIQ) {
ret |= CPSR_F;
}
}
@@ -9647,10 +9648,7 @@ void arm_cpu_do_interrupt(CPUState *cs)
return;
}
- /* Hooks may change global state so BQL should be held, also the
- * BQL needs to be held for any modification of
- * cs->interrupt_request.
- */
+ /* Hooks may change global state so BQL should be held */
g_assert(qemu_mutex_iothread_locked());
arm_call_pre_el_change_hook(cpu);
@@ -9665,7 +9663,7 @@ void arm_cpu_do_interrupt(CPUState *cs)
arm_call_el_change_hook(cpu);
if (!kvm_enabled()) {
- cs->interrupt_request |= CPU_INTERRUPT_EXITTB;
+ cpu_interrupt_request_or(cs, CPU_INTERRUPT_EXITTB);
}
}
#endif /* !CONFIG_USER_ONLY */
diff --git a/target/arm/machine.c b/target/arm/machine.c
index b292549614..4f2099ecde 100644
--- a/target/arm/machine.c
+++ b/target/arm/machine.c
@@ -693,7 +693,7 @@ static int cpu_post_load(void *opaque, int version_id)
if (env->irq_line_state == UINT32_MAX) {
CPUState *cs = CPU(cpu);
- env->irq_line_state = cs->interrupt_request &
+ env->irq_line_state = cpu_interrupt_request(cs) &
(CPU_INTERRUPT_HARD | CPU_INTERRUPT_FIQ |
CPU_INTERRUPT_VIRQ | CPU_INTERRUPT_VFIQ);
}
--
2.17.1
- [Qemu-devel] [PATCH v7 35/73] i386: use cpu_reset_interrupt, (continued)
- [Qemu-devel] [PATCH v7 35/73] i386: use cpu_reset_interrupt, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 25/73] s390x: convert to cpu_halted, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 36/73] s390x: use cpu_reset_interrupt, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 33/73] ppc: use cpu_reset_interrupt, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 66/73] riscv: convert to cpu_has_work_with_iothread_lock, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 53/73] alpha: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 51/73] nios: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 47/73] hppa: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 61/73] cpu: call .cpu_has_work with the CPU lock held, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 59/73] accel/tcg: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 38/73] arm: convert to cpu_interrupt_request,
Emilio G. Cota <=
- [Qemu-devel] [PATCH v7 49/73] m68k: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 54/73] moxie: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 42/73] i386/whpx-all: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 67/73] sparc: convert to cpu_has_work_with_iothread_lock, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 69/73] cpu: rename all_cpu_threads_idle to qemu_tcg_rr_all_cpu_threads_idle, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 39/73] i386: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 45/73] sh4: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 55/73] sparc: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 68/73] xtensa: convert to cpu_has_work_with_iothread_lock, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 46/73] cris: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04