Re: [Qemu-devel] [PULL 1/7] ui/cocoa: Ensure we have the iothread lock when calling into QEMU

[Peter Maydell]

On Mon, 4 Mar 2019 at 17:45, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Hi Peter,
>
> On 3/4/19 5:49 PM, Peter Maydell wrote:
> > The Cocoa UI should run on the main thread; this is enforced
> > in OSX Mojave. In order to be able to run on the main thread,
> > we need to make sure we hold the iothread lock whenever we
> > call into various QEMU UI midlayer functions.
> >
> > Signed-off-by: Peter Maydell <address@hidden>
> > Reviewed-by: Roman Bolshakov <address@hidden>
> > Tested-by: Roman Bolshakov <address@hidden>
>
> I got surprised by your 2 Message-id lines (same with other patches from
> this pull request):
>
> > Message-id: address@hidden
>
> ^ v3
>
> > Message-id: address@hidden

I think the 'patches' program tends to add an extra
Message-id: line even if one was already present. I treat
this header as pure noise and do not attempt to either add
it or remove it by hand.

thanks
-- PMM