[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/arm: Fix PC test for LDM (exception retu
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] target/arm: Fix PC test for LDM (exception return) |
|
Date: |
Sat, 2 Mar 2019 20:10:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/1/19 9:29 PM, Richard Henderson wrote:
> Found by inspection: Rn is the base register against which the
> load began; I is the register within the mask being processed.
> The exception return should of course be procesed from the loaded PC.
"processed"
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/arm/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 8f7f5b95aa..ad879e3480 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -10612,7 +10612,7 @@ static void disas_arm_insn(DisasContext *s, unsigned
> int insn)
> } else if (i == rn) {
> loaded_var = tmp;
> loaded_base = 1;
> - } else if (rn == 15 && exc_return) {
> + } else if (i == 15 && exc_return) {
> store_pc_exc_ret(s, tmp);
> } else {
> store_reg_from_load(s, i, tmp);
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>