Re: [Qemu-devel] [PATCH RFC v3 00/11] Add RX archtecture support

[Philippe Mathieu-Daudé]

Hi Yoshinori,

On 3/2/19 7:21 AM, Yoshinori Sato wrote:
> Hello.
> This patch series is added Renesas RX target emulation.
> 
> My git repository is bellow.
> git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git
> 
> Since my understanding is not enough,
> I want many comments to make this a good one.

OK :)

Can you provide notes about how to test your port?
Such: links to toolchains, how to build, what firmware/OS we can run...

> 
> Thanks.
> 
> Changes v2
> Rewrite translate. using decodetree.py
> 
> Yoshinori Sato (11):
>   target/rx: TCG Translation
>   target/rx: TCG helper
>   target/rx: CPU definition
>   target/rx: RX disassembler
>   target/rx: miscellaneous functions
>   RX62N interrupt contorol uint
>   RX62N internal timer modules
>   RX62N internal serial communication interface
>   RX Target hardware definition
>   Add rx-softmmu
>   MAINTAINERS: Add RX entry.
> 
>  MAINTAINERS                    |   20 +
>  arch_init.c                    |    2 +
>  configure                      |    8 +
>  default-configs/rx-softmmu.mak |    7 +
>  hw/char/Makefile.objs          |    2 +-
>  hw/char/renesas_sci.c          |  288 ++++++
>  hw/intc/Makefile.objs          |    1 +
>  hw/intc/rx_icu.c               |  323 ++++++
>  hw/rx/Makefile.objs            |    1 +
>  hw/rx/rx62n.c                  |  227 ++++
>  hw/rx/rxqemu.c                 |  100 ++
>  hw/timer/Makefile.objs         |    2 +
>  hw/timer/renesas_cmt.c         |  235 +++++
>  hw/timer/renesas_tmr.c         |  412 ++++++++
>  include/disas/bfd.h            |    5 +
>  include/hw/char/renesas_sci.h  |   42 +
>  include/hw/intc/rx_icu.h       |   49 +
>  include/hw/rx/rx.h             |    7 +
>  include/hw/rx/rx62n.h          |   54 +
>  include/hw/timer/renesas_cmt.h |   33 +
>  include/hw/timer/renesas_tmr.h |   42 +
>  include/sysemu/arch_init.h     |    1 +
>  target/rx/Makefile.objs        |   11 +
>  target/rx/cpu-qom.h            |   52 +
>  target/rx/cpu.c                |  224 ++++
>  target/rx/cpu.h                |  214 ++++
>  target/rx/disas.c              | 1570 ++++++++++++++++++++++++++++
>  target/rx/gdbstub.c            |  113 ++
>  target/rx/helper.c             |  252 +++++
>  target/rx/helper.h             |   39 +
>  target/rx/insns.decode         |  336 ++++++
>  target/rx/monitor.c            |   38 +
>  target/rx/op_helper.c          |  602 +++++++++++
>  target/rx/translate.c          | 2220 
> ++++++++++++++++++++++++++++++++++++++++
>  34 files changed, 7531 insertions(+), 1 deletion(-)
>  create mode 100644 default-configs/rx-softmmu.mak
>  create mode 100644 hw/char/renesas_sci.c
>  create mode 100644 hw/intc/rx_icu.c
>  create mode 100644 hw/rx/Makefile.objs
>  create mode 100644 hw/rx/rx62n.c
>  create mode 100644 hw/rx/rxqemu.c
>  create mode 100644 hw/timer/renesas_cmt.c
>  create mode 100644 hw/timer/renesas_tmr.c
>  create mode 100644 include/hw/char/renesas_sci.h
>  create mode 100644 include/hw/intc/rx_icu.h
>  create mode 100644 include/hw/rx/rx.h
>  create mode 100644 include/hw/rx/rx62n.h
>  create mode 100644 include/hw/timer/renesas_cmt.h
>  create mode 100644 include/hw/timer/renesas_tmr.h
>  create mode 100644 target/rx/Makefile.objs
>  create mode 100644 target/rx/cpu-qom.h
>  create mode 100644 target/rx/cpu.c
>  create mode 100644 target/rx/cpu.h
>  create mode 100644 target/rx/disas.c
>  create mode 100644 target/rx/gdbstub.c
>  create mode 100644 target/rx/helper.c
>  create mode 100644 target/rx/helper.h
>  create mode 100644 target/rx/insns.decode
>  create mode 100644 target/rx/monitor.c
>  create mode 100644 target/rx/op_helper.c
>  create mode 100644 target/rx/translate.c
>