qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/7] qapi: Pass file name to QAPIGen constructor


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 3/7] qapi: Pass file name to QAPIGen constructor instead of methods
Date: Fri, 1 Mar 2019 09:49:53 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0

On 3/1/19 9:40 AM, Markus Armbruster wrote:
> Not much of an improvement now, but the next commit will profit.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi/commands.py |  2 +-
>  scripts/qapi/common.py   | 68 +++++++++++++++++++++-------------------
>  scripts/qapi/doc.py      |  4 +--
>  3 files changed, 38 insertions(+), 36 deletions(-)
> 
Looks like a straightforward refactoring, and I can indeed guess how it
becomes useful later.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]