[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] qapi: Pass file name to QAPIGen constructor
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] qapi: Pass file name to QAPIGen constructor instead of methods |
Date: |
Fri, 1 Mar 2019 09:49:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 3/1/19 9:40 AM, Markus Armbruster wrote:
> Not much of an improvement now, but the next commit will profit.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi/commands.py | 2 +-
> scripts/qapi/common.py | 68 +++++++++++++++++++++-------------------
> scripts/qapi/doc.py | 4 +--
> 3 files changed, 38 insertions(+), 36 deletions(-)
>
Looks like a straightforward refactoring, and I can indeed guess how it
becomes useful later.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PATCH 0/7] qapi: Code generation fixes, Markus Armbruster, 2019/03/01
- [Qemu-devel] [PATCH 6/7] tests/qapi-schema: Cover forward reference to sub-module, Markus Armbruster, 2019/03/01
- [Qemu-devel] [PATCH 7/7] qapi: Fix array first used in a different module, Markus Armbruster, 2019/03/01
- [Qemu-devel] [PATCH 4/7] qapi: Fix code generation for sub-modules in other directories, Markus Armbruster, 2019/03/01
- [Qemu-devel] [PATCH 3/7] qapi: Pass file name to QAPIGen constructor instead of methods, Markus Armbruster, 2019/03/01
- Re: [Qemu-devel] [PATCH 3/7] qapi: Pass file name to QAPIGen constructor instead of methods,
Eric Blake <=
- [Qemu-devel] [PATCH 5/7] tests: Rename UserDefNativeListUnion to UserDefListUnion, Markus Armbruster, 2019/03/01
- [Qemu-devel] [PATCH 2/7] tests/qapi-schema: Cover conditional arrays, Markus Armbruster, 2019/03/01
- [Qemu-devel] [PATCH 1/7] tests/qapi-schema: Make test-qapi.py print arrays, Markus Armbruster, 2019/03/01