[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig |
Date: |
Tue, 26 Feb 2019 16:25:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 26/02/19 14:44, Markus Armbruster wrote:
> Paolo Bonzini <address@hidden> writes:
>
>> On 25/02/19 09:44, Stefano Garzarella wrote:
>>>> config I440FX
>>>> bool
>>>> + select PC_PCI
>>>> + select PC_ACPI
>>>> + select ACPI_SMBUS
>>>> + select PCI_PIIX
>>>> + select FDC
>>> Should we move "select FDC" under "config PC"?
>>>
>>> I'm not able to build the Q35 machine without enable FDC, since some fdc
>>> functions are used in hw/i386/pc.c (eg. isa_fdc_get_drive_type())
>>
>> Yes, that's a good idea. I mistakenly thought that Q35 could be built
>> without FDC.
>
> Could we add stubs to make it buildable that way?
Of course I'm ecstatic that one benefit of Kconfig (finding suboptimal
dependencies) is already being realized _before_ it lands, but not now.
However, those kind of cleanups can wait for 4.1. :)
Note that we're doing the most important cleanups (e.g. not having to
bring PCI into boards that don't need it), but overall this series will
be about 120 patches and it's already a half miracle that everything was
done in <2 months and it will be already in 4.0.
Paolo
- [Qemu-devel] [PATCH 14/51] block: fix recursion in hw/block/dataplane, (continued)
- [Qemu-devel] [PATCH 14/51] block: fix recursion in hw/block/dataplane, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 02/51] minikconfig: add AST, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 15/51] scsi: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 13/51] build: convert usb.mak to Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 16/51] isa: express dependencies with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 01/51] minikconfig: add parser skeleton, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
Re: [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig, Thomas Huth, 2019/02/26
[Qemu-devel] [PATCH 11/51] build: convert pci.mak to Kconfig, Paolo Bonzini, 2019/02/07
[Qemu-devel] [PATCH 21/51] hyperv: express dependencies with kconfig, Paolo Bonzini, 2019/02/07
[Qemu-devel] [PATCH 03/51] minikconfig: add semantic analysis, Paolo Bonzini, 2019/02/07
[Qemu-devel] [PATCH 24/51] tpm: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
[Qemu-devel] [PATCH 18/51] i2c: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
[Qemu-devel] [PATCH 19/51] ptimer: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
[Qemu-devel] [PATCH 05/51] kconfig: introduce kconfig files, Paolo Bonzini, 2019/02/07