[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] block/ssh: Implement .bdrv_refresh_filen
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] block/ssh: Implement .bdrv_refresh_filename() |
Date: |
Mon, 25 Feb 2019 15:10:06 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 25.02.19 14:39, Max Reitz wrote:
> On 06.02.19 16:29, Max Reitz wrote:
>> This series implements .bdrv_refresh_filename() for the ssh block
>> driver, along with an appropriate .bdrv_dirname() so we don't chop off
>> query strings for backing files with relative filenames.
>>
>> This series depends on my "block: Fix some filename generation issues"
>> series.
>>
>> Based-on: address@hidden
>>
>>
>> v2:
>> - No longer based on the libssh2 -> libssh patches
>> - Put /* and */ on their own lines to make checkpatch happy
>>
>>
>> Max Reitz (2):
>> block/ssh: Implement .bdrv_refresh_filename()
>> block/ssh: Implement .bdrv_dirname()
>>
>> block/ssh.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++----
>> 1 file changed, 68 insertions(+), 5 deletions(-)
>
> Thanks for having had a look at this series, Rich; I've applied it to my
> block branch.
Or maybe not. It breaks iotests 104 (because the filename now includes
your username) and 207 (because the json:{} filename is a nice filename
now). So I'll drop it and send a v3.
Max
signature.asc
Description: OpenPGP digital signature