Re: [Qemu-devel] [PATCH 06/51] build: switch to Kconfig

[Paolo Bonzini]

On 21/02/19 16:44, Stefano Garzarella wrote:
>> +
> Hi Paolo,
> I'm playing with Kconfig but with a simple configuration
> (./configure --target-list=x86_64-softmmu --disable-docs) the build fails:
> /usr/bin/ld: ../hw/xen/xen-legacy-backend.o: in function 
> `xen_be_register_common':
> /home/stefano/repos/qemu-kconfig/hw/xen/xen-legacy-backend.c:757: undefined 
> reference to `xen_9pfs_ops'
> collect2: error: ld returned 1 exit status
> 
> Analyzing the Makefile.objs files maybe we should pass the CONFIG_VIRTFS from
> config-host.mak down to Kconfig.
> I tried this simple patch and it seems to fix the issue:
> 
> diff --git a/Makefile b/Makefile
> index df0732a050..bad583b01c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -336,6 +336,7 @@ MINIKCONF_ARGS = \
>      CONFIG_XEN=$(CONFIG_XEN) \
>      CONFIG_OPENGL=$(CONFIG_OPENGL) \
>      CONFIG_VHOST_USER=$(CONFIG_VHOST_USER) \
> +    CONFIG_VIRTFS=$(CONFIG_VIRTFS) \
>      CONFIG_LINUX=$(CONFIG_LINUX)
> 
> I'm not sure if we need to add "config VIRTFS" entry in the
> Kconfig.host, because it is already defined in hw/9pfs/Kconfig.

Yes, we should remove it from hw/9pfs/Kconfig too.  I had made this
exact change today in my branch. :)

Thanks!

Paolo