[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 03/11] spice: avoid spice runtime assert
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v3 03/11] spice: avoid spice runtime assert |
Date: |
Thu, 21 Feb 2019 12:06:55 +0100 |
The Spice server doesn't like to be started or stopped twice . It
aborts with:
(process:6191): Spice-ERROR **: 19:29:35.912:
red-worker.c:623:handle_dev_start: assertion `!worker->running' failed
It's easy to avoid that situation since qemu spice_display_is_running
tracks the server state.
After the commit "spice: do not stop spice if VM is paused", it will
be possible to pause and resume the VM, and this will call
qemu_spice_display_start() twice. The easiest is to add a check for
spice_display_is_running with this patch to avoid the assert.
Signed-off-by: Marc-André Lureau <address@hidden>
Tested-by: Victor Toso <address@hidden>
---
ui/spice-core.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index a40fb2c00d..94b31ce3ad 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -921,12 +921,20 @@ int qemu_spice_display_add_client(int csock, int
skipauth, int tls)
void qemu_spice_display_start(void)
{
+ if (spice_display_is_running) {
+ return;
+ }
+
spice_display_is_running = true;
spice_server_vm_start(spice_server);
}
void qemu_spice_display_stop(void)
{
+ if (!spice_display_is_running) {
+ return;
+ }
+
spice_server_vm_stop(spice_server);
spice_display_is_running = false;
}
--
2.21.0.rc1
- [Qemu-devel] [PATCH v3 00/11] spice: add -display spice-app, setup and launch a Spice client, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 01/11] char/spice: trigger HUP event, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 03/11] spice: avoid spice runtime assert,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 02/11] char/spice: discard write() if backend is disconnected, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 04/11] spice: merge options lists, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 05/11] spice: do not stop spice if VM is paused, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 06/11] char: move SpiceChardev and open_spice_port() to spice.h header, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 07/11] char: register spice ports after spice started, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 08/11] build-sys: add gio-2.0 check, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 09/11] qapi: document DisplayType enum, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 10/11] spice: use a default name for the server, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 11/11] display: add -display spice-app launching a Spice client, Marc-André Lureau, 2019/02/21