Re: [Qemu-devel] [PATCH v2 2/9] tests/tcg: target/mips: Correct path to headers in some test source files

[Aleksandar Markovic]

Hello, Max!

> From: Max Filippov <address@hidden>
> Subject: Re: [Qemu-devel] [PATCH v2 2/9] tests/tcg: target/mips: Correct path 
> to headers in some test source files

> > -#include "../../../include/wrappers_msa.h"
> > -#include "../../../include/test_inputs.h"
> > -#include "../../../include/test_utils.h"
> > +#include "../../../../include/wrappers_msa.h"
> > +#include "../../../../include/test_inputs.h"
> > +#include "../../../../include/test_utils.h"

> Wouldn't it be better to have path to include directory
> somewhere in the CPPFLAGS, outside the test source code?

Eventually these paths will be covered by CPPFLAGS, or similar.
However, the whole directory tests/tcg/mips is undergoing a serious
reorganization, and I have a strong impression that build/makefile
infrastructure would be better off added at the end of that process.
The additional challenge is that all these tests (like any other ones
in tests/tcg) are supposed to be cross-compiled.

That said, all added files are tested via manual build and execution
both on hardware and within QEMU (but the mistake that this patch
fixes slipped thorough the cracks). Large number of tests cases (in
the range of thousands so far) are executed in fairly short amount
of time (matter of seconds).

In any case, thanks!

Aleksandar