Re: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
918b511857 hw/arm hw/xtensa: De-duplicate pflash creation code some
573a3cb6ee pflash: Clean up after commit 368a354f02b part 2
cd6c8874c9 pflash: Clean up after commit 368a354f02b part 1
47d6b05dbf mips_malta: Clean up definition of flash memory size somewhat
4d776997cb r2d: Flash memory creation is confused about size, mark FIXME
8ef649b622 ppc405_boards: Don't size flash memory to match backing image
05e5efce12 sam460ex: Don't size flash memory to match backing image
83454272f9 hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
e25489f667 pflash: Macro PFLASH_BUG() is used just once, expand
23cedcc198 pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02

=== OUTPUT BEGIN ===
1/10 Checking commit 23cedcc198b7 (pflash: Rename pflash_t to PFlashCFI01, 
PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,

ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,

ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,

total: 3 errors, 0 warnings, 483 lines checked

Patch 1/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/10 Checking commit e25489f66779 (pflash: Macro PFLASH_BUG() is used just 
once, expand)
3/10 Checking commit 83454272f952 (hw: Use CFI_PFLASH0{1, 2} and 
TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit 05e5efce1273 (sam460ex: Don't size flash memory to match 
backing image)
5/10 Checking commit 8ef649b622cf (ppc405_boards: Don't size flash memory to 
match backing image)
6/10 Checking commit 4d776997cb7d (r2d: Flash memory creation is confused about 
size, mark FIXME)
7/10 Checking commit 47d6b05dbf10 (mips_malta: Clean up definition of flash 
memory size somewhat)
8/10 Checking commit cd6c8874c9f4 (pflash: Clean up after commit 368a354f02b 
part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#91: FILE: hw/arm/musicpal.c:1639:
+        pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
                                             ^

ERROR: spaces required around that '-' (ctx:VxV)
#99: FILE: hw/arm/musicpal.c:1646:
+        pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
                                             ^

total: 2 errors, 0 warnings, 248 lines checked

Patch 8/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/10 Checking commit 573a3cb6eeac (pflash: Clean up after commit 368a354f02b 
part 2)
10/10 Checking commit 918b5118573b (hw/arm hw/xtensa: De-duplicate pflash 
creation code some)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden