Re: [Qemu-devel] [PATCH 06/10] r2d: Flash memory creation is confused about size, mark FIXME

[Peter Maydell]

On Mon, 18 Feb 2019 at 13:07, Markus Armbruster <address@hidden> wrote:
>
> pflash_cfi02_register() takes a size in bytes, a block size in bytes
> and a number of blocks.  r2d_init() passes FLASH_SIZE, 16 * KiB,
> FLASH_SIZE >> 16.  Does not compute: size doesn't match block size *
> number of blocks.  The latter happens to win.  I tried to find
> documentation on the physcial hardware, no luck.
>
> For now, adjust the byte size passed to match the actual size created,
> and add a FIXME comment.

I'm pretty sure that FLASH_SIZE here is supposed to be a
byte count of the size of the pflash. That matches what
Linux has in arch/sh/boards/mach-r2d/setup.c where it
sets up the flash_resource struct.

The r2dplus board is also I think known as RTS7751R2D. That
takes us to https://elinux.org/RTS7751R2D_Handling_Manual
(sadly the link to the "hardware manual" is broken).

No idea what the block size would be.


thanks
-- PMM