qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop


From: no-reply
Subject: Re: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Date: Thu, 14 Feb 2019 09:52:12 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0538b64902 ui/cocoa: Perform UI operations only on the main thread
9c813776c5 ui/cocoa: Subclass NSApplication so we can implement sendEvent
ee910daa7f ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
475c73329c ui/cocoa: Move console/device menu creation code up in file
84187b00a1 ui/cocoa: Factor out initial menu creation
ec9d2d35f1 ui/cocoa: Use the pixman image directly in switchSurface
31e3ce4546 ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit 31e3ce4546b9 (ui/cocoa: Ensure we have the iothread lock 
when calling into QEMU)
2/7 Checking commit ec9d2d35f160 (ui/cocoa: Use the pixman image directly in 
switchSurface)
3/7 Checking commit 84187b00a139 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit 475c73329cdd (ui/cocoa: Move console/device menu creation 
code up in file)
5/7 Checking commit ee910daa7f20 (ui/cocoa: Don't call NSApp sendEvent directly 
from handleEvent)
ERROR: trailing whitespace
#42: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 9c813776c52a (ui/cocoa: Subclass NSApplication so we can 
implement sendEvent)
7/7 Checking commit 0538b64902ce (ui/cocoa: Perform UI operations only on the 
main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]