[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 5/6] hw/mips_cpc: kick a VP when putting it into
From: |
Aleksandar Markovic |
Subject: |
[Qemu-devel] [PATCH v3 5/6] hw/mips_cpc: kick a VP when putting it into Run statewq |
Date: |
Mon, 11 Feb 2019 17:31:23 +0100 |
From: Miodrag Dinic <address@hidden>
While testing mttcg VP0 could get stuck in a loop waiting for other
VPs to come up (which never actually happens). To fix this, kick VPs
while they are being powered up by Cluster Power Controller in an
async task which is triggered once the host thread is being spawned.
Signed-off-by: Miodrag Dinic <address@hidden>
Signed-off-by: Leon Alrae <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Acked-by: Alex Bennée <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
---
hw/misc/mips_cpc.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/hw/misc/mips_cpc.c b/hw/misc/mips_cpc.c
index 6d34574..712d842 100644
--- a/hw/misc/mips_cpc.c
+++ b/hw/misc/mips_cpc.c
@@ -30,6 +30,14 @@ static inline uint64_t cpc_vp_run_mask(MIPSCPCState *cpc)
return (1ULL << cpc->num_vp) - 1;
}
+static void mips_cpu_reset_async_work(CPUState *cs, run_on_cpu_data data)
+{
+ MIPSCPCState *cpc = (MIPSCPCState *) data.host_ptr;
+
+ cpu_reset(cs);
+ cpc->vp_running |= 1ULL << cs->cpu_index;
+}
+
static void cpc_run_vp(MIPSCPCState *cpc, uint64_t vp_run)
{
CPUState *cs = first_cpu;
@@ -37,8 +45,13 @@ static void cpc_run_vp(MIPSCPCState *cpc, uint64_t vp_run)
CPU_FOREACH(cs) {
uint64_t i = 1ULL << cs->cpu_index;
if (i & vp_run & ~cpc->vp_running) {
- cpu_reset(cs);
- cpc->vp_running |= i;
+ /*
+ * To avoid racing with a CPU we are just kicking off.
+ * We do the final bit of preparation for the work in
+ * the target CPUs context.
+ */
+ async_safe_run_on_cpu(cs, mips_cpu_reset_async_work,
+ RUN_ON_CPU_HOST_PTR(cpc));
}
}
}
--
2.7.4
- [Qemu-devel] [PATCH v3 0/6] target-mips: support MTTCG feature, Aleksandar Markovic, 2019/02/11
- [Qemu-devel] [PATCH v3 4/6] target/mips: hold BQL in mips_vpe_wake(), Aleksandar Markovic, 2019/02/11
- [Qemu-devel] [PATCH v3 6/6] target/mips: introduce MTTCG-enabled builds, Aleksandar Markovic, 2019/02/11
- [Qemu-devel] [PATCH v3 1/6] target/mips: compare virtual addresses in LL/SC sequence, Aleksandar Markovic, 2019/02/11
- [Qemu-devel] [PATCH v3 5/6] hw/mips_cpc: kick a VP when putting it into Run statewq,
Aleksandar Markovic <=
- [Qemu-devel] [PATCH v3 3/6] hw/mips_int: hold BQL for all interrupt requests, Aleksandar Markovic, 2019/02/11
- [Qemu-devel] [PATCH v3 2/6] target/mips: reimplement SC instruction emulation and use cmpxchg, Aleksandar Markovic, 2019/02/11