[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp80
|
From: |
Andrew Baumann |
|
Subject: |
Re: [Qemu-devel] [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike timer |
|
Date: |
Mon, 11 Feb 2019 04:15:11 +0000 |
Hi Mark,
> From: Mark <address@hidden>
> Sent: Sunday, 10 February 2019 08:58
> Subject: [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike
> timer
Thanks for the patch. The integration with bcm2835_peripherals looks good, but
hopefully one of the QEMU maintainers can give you a review of the timer
implementation as I'm really short on time at the moment.
If you didn't already see it, you may want to compare with the implementation
here, which originates from Gregory Estrade:
https://github.com/0xabu/qemu/blob/raspi/hw/timer/bcm2835_timer.c
... sadly I never got around to merging it upstream with the rest of the raspi
emulation. ☹
Cheers,
Andrew