Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

[Paolo Bonzini]

On 08/02/19 17:00, Kevin Wolf wrote:
> Am 08.02.2019 um 14:46 hat Paolo Bonzini geschrieben:
>> On 08/02/19 13:48, Kevin Wolf wrote:
>>> I just wanted to work on a unit test and found that a simple 'make
>>> check-tests/test-bdrv-drain' (which used to build and run the test with
>>> a single command) doesn't work any more.
>>>
>>> git bisect points to this commit.
>>
>> What's wrong with "tests/test-bdrv-drain"?  (Before there were some
>> differences in test environment, but not now).
> 
> It runs the old version without building the source I just modified.

Oh.  Since it wasn't documented, it seemed to be just an implementation
detail rather than something that would be used by people...  So
basically something like this?

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 048cf5639c..6ac3f2c7eb 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -861,6 +861,9 @@ check-unit: $(check-unit-y)
 check-speed: $(check-speed-y)
        $(call do_test_human, $^)

+$(patsubst %, check-%, $(check-unit-y) $(check-speed-y): check-%: %
+        $<
+
 # gtester tests with TAP output

 $(patsubst %, check-report-qtest-%.tap, $(QTEST_TARGETS)):
check-report-qtest-%.tap: $(check-qtest-y)


Paolo