[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 39/73] i386: convert to cpu_interrupt_request
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v6 39/73] i386: convert to cpu_interrupt_request |
Date: |
Fri, 08 Feb 2019 11:00:23 +0000 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Emilio G. Cota <address@hidden> writes:
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/i386/cpu.c | 2 +-
> target/i386/helper.c | 4 ++--
> target/i386/svm_helper.c | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index a37b984b61..35dea8c152 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -5678,7 +5678,7 @@ int x86_cpu_pending_interrupt(CPUState *cs, int
> interrupt_request)
>
> static bool x86_cpu_has_work(CPUState *cs)
> {
> - return x86_cpu_pending_interrupt(cs, cs->interrupt_request) != 0;
> + return x86_cpu_pending_interrupt(cs, cpu_interrupt_request(cs))
> != 0;
This is fine in itself but is there a chance of a race with the
env->eflags/hflags/hflags2 that x86_cpu_pending_interrupt deals with?
Are they only ever self vCPU references?
Anyway:
Reviewed-by: Alex Bennée <address@hidden>
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v6 39/73] i386: convert to cpu_interrupt_request,
Alex Bennée <=