[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 8/8] iotests: qcow2's encrypt.format is now o
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 8/8] iotests: qcow2's encrypt.format is now optional |
Date: |
Wed, 6 Feb 2019 15:31:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/6/19 1:55 PM, Max Reitz wrote:
> Remove the encrypt.format option from the two blockdev-add test cases
> for encrypted qcow2 images in 087 to explicitly test that this parameter
> is now optional.
>
> Additionally, show that explicitly specifying encrypt.format=auto works
> just as well, the same for specifying the correct format
> (encrypt.format=luks here), and that specifying the wrong format
> (encrypt.format=aes) results in an error.
>
> While touching this test case, reduce the LUKS iteration time to 10 so
> the test stays reasonably fast.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
> ---
> tests/qemu-iotests/087 | 65 +++++++++++++++++++++++---------------
> tests/qemu-iotests/087.out | 26 ++++++++++++++-
> 2 files changed, 64 insertions(+), 27 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 3/8] tests: Add QAPI optional discriminator tests, (continued)
- [Qemu-devel] [PATCH v3 3/8] tests: Add QAPI optional discriminator tests, Max Reitz, 2019/02/06
- [Qemu-devel] [PATCH v3 5/8] qapi: Formalize qcow encryption probing, Max Reitz, 2019/02/06
- [Qemu-devel] [PATCH v3 6/8] block: Try to create well typed json:{} filenames, Max Reitz, 2019/02/06
- [Qemu-devel] [PATCH v3 7/8] iotests: Test internal option typing, Max Reitz, 2019/02/06
- [Qemu-devel] [PATCH v3 8/8] iotests: qcow2's encrypt.format is now optional, Max Reitz, 2019/02/06
- Re: [Qemu-devel] [PATCH v3 8/8] iotests: qcow2's encrypt.format is now optional,
Eric Blake <=