[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf |
Date: |
Wed, 6 Feb 2019 18:09:21 +0000 |
06.02.2019 20:32, Eric Blake wrote:
> On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Use new qemu_iovec_init_buf() instead of
>> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Did you just do a manual search for candidate callers?
>
> As you said in the cover letter, there are other files that can benefit
> as well; are you planning on making v3 of the series longer?
git grep qemu_iovec_init_external | grep 1
shows a lot of, exactly 34 after io.c already updated.
They are in different subsystems, so I think it should be simpler to push this
one as a precedent and example, and then send separate patches (or series)
per-maintainer.
hm, in other words:
# git grep -l 'qemu_iovec_init_external.*1'
block/backup.c
block/block-backend.c
block/commit.c
block/parallels.c
block/qcow.c
block/qcow2.c
block/qed-table.c
block/qed.c
block/stream.c
block/vmdk.c
hw/ide/atapi.c
hw/ide/core.c
hw/scsi/scsi-disk.c
migration/block.c
qemu-img.c
tests/test-bdrv-drain.c
>
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>> block/io.c | 90 +++++++++++++-----------------------------------------
>> 1 file changed, 21 insertions(+), 69 deletions(-)
>
> But I'm loving the diffstat - it is definitely a nice change.
>
> Reviewed-by: Eric Blake <address@hidden>
>
--
Best regards,
Vladimir