Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

[Eric Blake]

On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.

Did you just do a manual search for candidate callers?

As you said in the cover letter, there are other files that can benefit
as well; are you planning on making v3 of the series longer?

> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>  block/io.c | 90 +++++++++++++-----------------------------------------
>  1 file changed, 21 insertions(+), 69 deletions(-)

But I'm loving the diffstat - it is definitely a nice change.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature