[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 9/9] usb: remove unnecessary NULL device check fr
From: |
Liam Merwick |
Subject: |
[Qemu-devel] [PATCH v2 9/9] usb: remove unnecessary NULL device check from usb_ep_get() |
Date: |
Wed, 6 Feb 2019 13:36:56 +0000 |
No caller of usb_ep_get() calls it with a NULL device (previous commits
have addressed the few remaining cases which didn't explicitly check).
Replace check for 'dev == NULL' with an assert instead.
Signed-off-by: Liam Merwick <address@hidden>
---
hw/usb/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/usb/core.c b/hw/usb/core.c
index bfb7ae67bbf0..8fbd9c7d573b 100644
--- a/hw/usb/core.c
+++ b/hw/usb/core.c
@@ -717,9 +717,7 @@ struct USBEndpoint *usb_ep_get(USBDevice *dev, int pid, int
ep)
{
struct USBEndpoint *eps;
- if (dev == NULL) {
- return NULL;
- }
+ assert(dev != NULL);
if (ep == 0) {
return &dev->ep_ctl;
}
--
1.8.3.1
- [Qemu-devel] [PATCH v2 0/9] Dealing with Null devices in usb_ep_get(), Liam Merwick, 2019/02/06
- [Qemu-devel] [PATCH v2 1/9] usb: rearrange usb_ep_get(), Liam Merwick, 2019/02/06
- [Qemu-devel] [PATCH v2 5/9] ohci: check device is not NULL before calling usb_ep_get(), Liam Merwick, 2019/02/06
- [Qemu-devel] [PATCH v2 2/9] xhci: add asserts to help with static code analysis, Liam Merwick, 2019/02/06
- [Qemu-devel] [PATCH v2 3/9] xhci: check device is not NULL before calling usb_ep_get(), Liam Merwick, 2019/02/06
- [Qemu-devel] [PATCH v2 4/9] ehci: check device is not NULL before calling usb_ep_get(), Liam Merwick, 2019/02/06
- [Qemu-devel] [PATCH v2 8/9] usb: add device checks before redirector calls to usb_ep_get(), Liam Merwick, 2019/02/06
- [Qemu-devel] [PATCH v2 6/9] uhci: check device is not NULL before calling usb_ep_get(), Liam Merwick, 2019/02/06
- [Qemu-devel] [PATCH v2 7/9] usb: check device is not NULL before calling usb_ep_get(), Liam Merwick, 2019/02/06
- [Qemu-devel] [PATCH v2 9/9] usb: remove unnecessary NULL device check from usb_ep_get(),
Liam Merwick <=
- Re: [Qemu-devel] [PATCH v2 0/9] Dealing with Null devices in usb_ep_get(), Gerd Hoffmann, 2019/02/08