[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULLv3 17/32] slirp: improve windows headers inclusion
From: |
Samuel Thibault |
Subject: |
[Qemu-devel] [PULLv3 17/32] slirp: improve windows headers inclusion |
Date: |
Tue, 5 Feb 2019 20:28:33 +0200 |
From: Marc-André Lureau <address@hidden>
Our API usage requires Vista, set WIN32_LEAN_AND_MEAN to fix a number
of issues (winsock2.h include order for ex, which is better to include
first for legacy reasons).
While at it, group redundants #ifndef _WIN32 blocks.
Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Samuel Thibault <address@hidden>
---
slirp/slirp.h | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/slirp/slirp.h b/slirp/slirp.h
index 8d9d72ca9d..5a830ddcb8 100644
--- a/slirp/slirp.h
+++ b/slirp/slirp.h
@@ -3,10 +3,19 @@
#ifdef _WIN32
+/* as defined in sdkddkver.h */
+#ifndef _WIN32_WINNT
+#define _WIN32_WINNT 0x0600 /* Vista */
+#endif
+/* reduces the number of implicitly included headers */
+#ifndef WIN32_LEAN_AND_MEAN
+#define WIN32_LEAN_AND_MEAN
+#endif
+
typedef char *caddr_t;
-# include <windows.h>
# include <winsock2.h>
+# include <windows.h>
# include <ws2tcpip.h>
# include <sys/timeb.h>
# include <iphlpapi.h>
@@ -19,19 +28,10 @@ typedef char *caddr_t;
#ifndef _WIN32
#include <sys/uio.h>
-#endif
-
-#ifndef _WIN32
#include <netinet/in.h>
#include <arpa/inet.h>
-#endif
-
-#ifndef _WIN32
#include <sys/socket.h>
-#endif
-
-#ifndef _WIN32
-# include <sys/ioctl.h>
+#include <sys/ioctl.h>
#endif
#ifdef __APPLE__
--
2.20.1
- [Qemu-devel] [PULLv3 20/32] slirp: remove now useless QEMU headers inclusions, (continued)
- [Qemu-devel] [PULLv3 20/32] slirp: remove now useless QEMU headers inclusions, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 21/32] slirp: replace net/eth.h inclusion with own defines, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 24/32] slirp: Move g_spawn_async_with_fds_qemu compatibility to slirp/, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 16/32] slirp: do not include qemu headers in libslirp.h public API header, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 26/32] slirp: prefer c99 types over BSD kind, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 14/32] slirp: replace qemu_notify_event() with a callback, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 31/32] slirp: pass opaque to all callbacks, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 25/32] slirp: replace remaining qemu headers dependency, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 22/32] slirp: replace qemu qtailq with slirp own copy, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 27/32] slirp: improve send_packet() callback, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 17/32] slirp: improve windows headers inclusion,
Samuel Thibault <=
- [Qemu-devel] [PULLv3 32/32] slirp: API is extern C, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 29/32] slirp: remove slirp_instances list, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 23/32] slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 30/32] slirp: use polling callbacks, drop glib requirement, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 18/32] slirp: add slirp own version of pstrcpy, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 19/32] slirp: remove qemu timer.h dependency, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 15/32] slirp: move QEMU state saving to a separate unit, Samuel Thibault, 2019/02/05
- [Qemu-devel] [PULLv3 28/32] slirp: replace global polling with per-instance & notifier, Samuel Thibault, 2019/02/05
- Re: [Qemu-devel] [PULLv3 00/32] More work towards libslirp, no-reply, 2019/02/05
- Re: [Qemu-devel] [PULLv3 00/32] More work towards libslirp, no-reply, 2019/02/05