Re: [Qemu-devel] [PATCH V2] test-filter-mirror: pass UNIX domain socket through fd

[Peter Maydell]

On Wed, 30 Jan 2019 at 03:14, Jason Wang <address@hidden> wrote:
>
> The tests tries to let qemu server mode to process the connection
> which turns out to be racy after commit 8258292e18c3 ("monitor: Remove
> "x-oob", offer capability "oob" unconditionally"). This is because the
> filter may try to mirror the packets before UNIX socket object is
> ready (connected was set to true) from the view of qemu. In this case
> the packet will be dropped silently.
>
> Fixing this by passing pre-connected socket created by socketpair() to
> qemu through fd.

Hi; assuming it passes my merge tests I'm planning to apply
this directly to master since it will make my merge testing
easier. Thanks for tracking down and fixing the bug!

-- PMM