Re: [Qemu-devel] [PATCH v11 3/3] qemu-img info: bitmaps extension new test 239

[Kevin Wolf]

Am 04.02.2019 um 08:53 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 01.02.2019 20:14, Kevin Wolf wrote:
> > Am 31.01.2019 um 14:46 hat Andrey Shinkevich geschrieben:
> >> A new test file 239 added to the qemu-iotests set. It checks
> >> the output format of 'qemu-img info' for bitmaps extension of
> >> qcow2 specific information.
> >>
> >> Signed-off-by: Andrey Shinkevich <address@hidden>
> > 
> > 239 is already taken, so please rename this one. I usually search the
> > mailing list for "239.out" etc. until I find a number that nobody has
> > used even in a patch series yet.
> > 
> > Kevin
> > 
> 
> Interesting, wasn't it considered to give meaningful names to iotest files?
> like migrate.bitmaps or qemu-img.qcow2-bitmaps, namespace.test? And then
> we'll be able to ./check -qcow2 qemu-img.*. And all these conflicts in list
> will be resolved

You're not the first one to suggest this, and I don't think people ever
fundamentally objected to the idea. But noone implemented it either -
the current system is ugly, but it does kind of work in practice and
renaming files in the repo always comes with some cost like 'git blame'
and 'git log' stopping at the rename by default.

Kevin