Re: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture 
support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
6655fa7 Boot Linux Console Test: add a test for alpha + clipper
f6dd48f Boot Linux Console Test: add a test for s390x + s390-ccw-virtio
018f196 Boot Linux Console Test: add a test for arm + virt
1b3a235 Boot Linux Console Test: add a test for aarch64 + virt
a72b513 Boot Linux Console Test: add a test for ppc64 + pseries
53b6bd6 Boot Linux Console Test: add a test for mips64el + malta
9e99bc7 Boot Linux Console Test: add a test for mips + malta
ad537d2 scripts/qemu.py: support adding a console with the default serial device
a90473b Boot Linux Console Test: refactor the console watcher into utility 
method
31e1e8e Boot Linux Console Test: increase timeout
71fd9a8 Boot Linux Console Test: add common kernel command line options
1f01854 Boot Linux Console Test: update the x86_64 kernel
fd958ac Boot Linux Console Test: rename the x86_64 after the arch and machine
5353486 Acceptance tests: look for target architecture in test tags first
0eec679 Acceptance tests: use "arch:" tag to filter target specific tests
d8bdead Acceptance tests: introduce arch parameter and attribute
68ac450 Acceptance tests: fix doc reference to avocado_qemu directory
4ef4e6b Acceptance tests: improve docstring on pick_default_qemu_bin()
9255bba Acceptance tests: show avocado test execution by default
3401845 scripts/qemu.py: log QEMU launch command line

=== OUTPUT BEGIN ===
1/20 Checking commit 3401845f7eb9 (scripts/qemu.py: log QEMU launch command 
line)
2/20 Checking commit 9255bba791a8 (Acceptance tests: show avocado test 
execution by default)
3/20 Checking commit 4ef4e6bab129 (Acceptance tests: improve docstring on 
pick_default_qemu_bin())
4/20 Checking commit 68ac450c2b81 (Acceptance tests: fix doc reference to 
avocado_qemu directory)
5/20 Checking commit d8bdead7f506 (Acceptance tests: introduce arch parameter 
and attribute)
6/20 Checking commit 0eec679cae2b (Acceptance tests: use "arch:" tag to filter 
target specific tests)
7/20 Checking commit 5353486417ba (Acceptance tests: look for target 
architecture in test tags first)
8/20 Checking commit fd958acfdb06 (Boot Linux Console Test: rename the x86_64 
after the arch and machine)
9/20 Checking commit 1f018544557b (Boot Linux Console Test: update the x86_64 
kernel)
10/20 Checking commit 71fd9a85460e (Boot Linux Console Test: add common kernel 
command line options)
11/20 Checking commit 31e1e8e772d2 (Boot Linux Console Test: increase timeout)
12/20 Checking commit a90473b9e34b (Boot Linux Console Test: refactor the 
console watcher into utility method)
13/20 Checking commit ad537d2fcc3d (scripts/qemu.py: support adding a console 
with the default serial device)
14/20 Checking commit 9e99bc7ca7b3 (Boot Linux Console Test: add a test for 
mips + malta)
15/20 Checking commit 53b6bd6a83fb (Boot Linux Console Test: add a test for 
mips64el + malta)
ERROR: line over 90 characters
#61: FILE: tests/acceptance/boot_linux_console.py:116:
+        [1] 
http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-source-2.6.32_2.6.32-48

ERROR: line over 90 characters
#62: FILE: tests/acceptance/boot_linux_console.py:117:
+        [2] 
https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s-common-official

total: 2 errors, 0 warnings, 49 lines checked

Patch 15/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/20 Checking commit a72b513a0156 (Boot Linux Console Test: add a test for 
ppc64 + pseries)
17/20 Checking commit 1b3a2357bc57 (Boot Linux Console Test: add a test for 
aarch64 + virt)
WARNING: line over 80 characters
#51: FILE: tests/acceptance/boot_linux_console.py:170:
+        kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 
'console=ttyAMA0'

total: 0 errors, 1 warnings, 31 lines checked

Patch 17/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/20 Checking commit 018f1969af3b (Boot Linux Console Test: add a test for arm 
+ virt)
WARNING: line over 80 characters
#48: FILE: tests/acceptance/boot_linux_console.py:190:
+        kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 
'console=ttyAMA0'

total: 0 errors, 1 warnings, 30 lines checked

Patch 18/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/20 Checking commit f6dd48f84608 (Boot Linux Console Test: add a test for 
s390x + s390-ccw-virtio)
20/20 Checking commit 6655fa70dfc9 (Boot Linux Console Test: add a test for 
alpha + clipper)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden