qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] nbd: generalize usage of nbd_read


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] nbd: generalize usage of nbd_read
Date: Fri, 1 Feb 2019 12:34:36 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 2/1/19 12:27 PM, Eric Blake wrote:

> 
> 
>> +
>> +#define DEF_NBD_READ(bits) \
>> +static inline int nbd_read ## bits(QIOChannel *ioc, uint ## bits ## _t * 
>> val, \
> 
> checkpatch didn't flag it, but I think our style is '*val', not '* val'.

But it DOES flag '*val' as a false positive.  Oh well.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]