Re: [Qemu-devel] [PATCH v6 00/35] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 00/35] target/riscv: Convert to decodetree
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
278051918f target/riscv: Remaining rvc insn reuse 32 bit translators
a87e6e35fb target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
24bff9f4ba target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
726e1f43c1 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
9420608fc4 target/riscv: Convert @cs_2 insns to share translation functions
0a0f1b7336 target/riscv: Remove decode_RV32_64G()
5c1a51d989 target/riscv: Remove gen_system()
a68220d0d8 target/riscv: Rename trans_arith to gen_arith
c0ff41680c target/riscv: Remove manual decoding of RV32/64M insn
aceeea6940 target/riscv: Remove shift and slt insn manual decoding
4177aa12cb target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
31b5b053d0 target/riscv: Move gen_arith_imm() decoding into trans_* functions
b09a386410 target/riscv: Remove manual decoding from gen_store()
4a66d1683e target/riscv: Remove manual decoding from gen_load()
1504f31cfb target/riscv: Remove manual decoding from gen_branch()
3fc86b5718 target/riscv: Remove gen_jalr()
862c038e96 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
dadd6fd1cf target/riscv: Convert quadrant 1 of RVXC insns to decodetree
bbbd541526 target/riscv: Convert quadrant 0 of RVXC insns to decodetree
22275dc23a target/riscv: Convert RV priv insns to decodetree
6bd6eba713 target/riscv: Convert RV64D insns to decodetree
ae069ba722 target/riscv: Convert RV32D insns to decodetree
1589e74dbf target/riscv: Convert RV64F insns to decodetree
8857eb324d target/riscv: Convert RV32F insns to decodetree
b9b3a0b782 target/riscv: Convert RV64A insns to decodetree
098d10b6b7 target/riscv: Convert RV32A insns to decodetree
a23ebbba2f target/riscv: Convert RVXM insns to decodetree
11f193d691 target/riscv: Convert RVXI csr insns to decodetree
65c828ac40 target/riscv: Convert RVXI fence insns to decodetree
c99c1e3a78 target/riscv: Convert RVXI arithmetic insns to decodetree
1629aa4d6e target/riscv: Convert RV64I load/store insns to decodetree
49279f7f05 target/riscv: Convert RV32I load/store insns to decodetree
4af4026ba5 target/riscv: Convert RVXI branch insns to decodetree
9ea6816814 target/riscv: Activate decodetree and implemnt LUI & AUIPC
9b28c37658 target/riscv: Move CPURISCVState pointer to DisasContext

=== OUTPUT BEGIN ===
1/35 Checking commit 9b28c3765893 (target/riscv: Move CPURISCVState pointer to 
DisasContext)
2/35 Checking commit 9ea68168149f (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

ERROR: externs should be avoided in .c files
#124: FILE: target/riscv/translate.c:1687:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 2/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/35 Checking commit 4af4026ba501 (target/riscv: Convert RVXI branch insns to 
decodetree)
4/35 Checking commit 49279f7f055e (target/riscv: Convert RV32I load/store insns 
to decodetree)
5/35 Checking commit 1629aa4d6ed2 (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 5/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/35 Checking commit c99c1e3a7803 (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
7/35 Checking commit 65c828ac4004 (target/riscv: Convert RVXI fence insns to 
decodetree)
8/35 Checking commit 11f193d69175 (target/riscv: Convert RVXI csr insns to 
decodetree)
9/35 Checking commit a23ebbba2fe1 (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 145 lines checked

Patch 9/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/35 Checking commit 098d10b6b754 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 188 lines checked

Patch 10/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/35 Checking commit b9b3a0b782df (target/riscv: Convert RV64A insns to 
decodetree)
12/35 Checking commit 8857eb324d81 (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#77: 
new file mode 100644

total: 0 errors, 1 warnings, 397 lines checked

Patch 12/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/35 Checking commit 1589e74dbfc1 (target/riscv: Convert RV64F insns to 
decodetree)
14/35 Checking commit ae069ba72242 (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 353 lines checked

Patch 14/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/35 Checking commit 6bd6eba7131e (target/riscv: Convert RV64D insns to 
decodetree)
16/35 Checking commit 22275dc23a4d (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 16/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/35 Checking commit bbbd541526d7 (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

ERROR: externs should be avoided in .c files
#245: FILE: target/riscv/translate.c:983:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 227 lines checked

Patch 17/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/35 Checking commit dadd6fd1cff0 (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
19/35 Checking commit 862c038e96e5 (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
20/35 Checking commit 3fc86b57189a (target/riscv: Remove gen_jalr())
21/35 Checking commit 1504f31cfb10 (target/riscv: Remove manual decoding from 
gen_branch())
22/35 Checking commit 4a66d1683e0d (target/riscv: Remove manual decoding from 
gen_load())
23/35 Checking commit b09a3864104f (target/riscv: Remove manual decoding from 
gen_store())
24/35 Checking commit 31b5b053d0b4 (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
25/35 Checking commit 4177aa12cb00 (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
26/35 Checking commit aceeea694040 (target/riscv: Remove shift and slt insn 
manual decoding)
27/35 Checking commit c0ff41680ca5 (target/riscv: Remove manual decoding of 
RV32/64M insn)
28/35 Checking commit a68220d0d81f (target/riscv: Rename trans_arith to 
gen_arith)
29/35 Checking commit 5c1a51d989de (target/riscv: Remove gen_system())
30/35 Checking commit 0a0f1b73365b (target/riscv: Remove decode_RV32_64G())
31/35 Checking commit 9420608fc4c4 (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

ERROR: externs should be avoided in .c files
#181: FILE: target/riscv/translate.c:497:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 31/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

32/35 Checking commit 726e1f43c1ae (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
33/35 Checking commit 24bff9f4baf8 (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 287 lines checked

Patch 33/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/35 Checking commit a87e6e35fb57 (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
35/35 Checking commit 278051918fff (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden