Re: [Qemu-devel] [PATCH for-4.0 00/11] qemu_thread_create: propagate the error to callers to handle

[Markus Armbruster]

I'm afraid you made a bit of a mess :)

"[PATCH for-4.0 00/11]" suggests this is v1 of eleven patches.

Fei Li <address@hidden> writes:

> Hi,
>
> This idea comes from BiteSizedTasks, and this patch series implement
> the error checking of qemu_thread_create: make qemu_thread_create
> return a flag to indicate if it succeeded rather than failing with
> an error; make all callers check it.
>
> The first patch modifies the qemu_thread_create() by passing
> &error_abort and returing a value to indicate if it succeeds. The next
> 10 patches will improve on &error_abort for callers who could handle
> more properly.
>
> Please help to review, thanks a lot! 
>
> v10:
> - Make qemu_thread_create() return -errno instead of a Boolean.
> - Add more cleanup for pci_edu_realize()/emulated_realize(). 
> - Polish for iothread_complete()/compress_threads_save_cleanup()/
>   vnc_start_worker_thread()/touch_all_pages.
> - Change to return H_HARDWARE for h_resize_hpt_prepare().
> - Remove five derivative patches as they have been merged.

It's actually v10.

[...]
> Fei Li (11):
>   qemu_thread: make qemu_thread_create() take Error ** argument
>   qemu_thread: supplement error handling for qemu_X_start_vcpu
>   qemu_thread: supplement error handling for qmp_dump_guest_memory
>   qemu_thread: supplement error handling for pci_edu_realize
>   qemu_thread: supplement error handling for h_resize_hpt_prepare
>   qemu_thread: supplement error handling for emulated_realize
>   qemu_thread: supplement error handling for iothread_complete
>   qemu_thread: supplement error handling for qemu_signalfd_compat
>   qemu_thread: supplement error handling for migration
>   qemu_thread: supplement error handling for vnc_start_worker_thread
>   qemu_thread: supplement error handling for touch_all_pages

It is eleven patches.  However, I got only 01-07/11 with this cover
letter.  A later batch (no cover letter) has 07-11/11 and 07-09/11
again.

I could guess which of the duplicates I should review, but that's work.
Just resend the whole thing as v11, please.

[...]