Re: [Qemu-devel] macOS build error after ddac19f534 (virtio: split virtio 9p bits from virtio-pci)

[BALATON Zoltan]

On Tue, 29 Jan 2019, BALATON Zoltan wrote:
> On Tue, 29 Jan 2019, Philippe Mathieu-Daudé wrote:
> > On 1/29/19 2:20 AM, BALATON Zoltan wrote:
> > > Hello,
> > >
> > > I'm getting error building on macOS after commit ddac19f534:
> > >
> > > ? CC????? aarch64-softmmu/hw/virtio/virtio-blk-pci.o
> > > In file included from qemu/hw/virtio/virtio-9p-pci.c:19:
> > > In file included from qemu/hw/9pfs/virtio-9p.h:6:
> > > In file included from qemu/hw/9pfs/9p.h:7:
> > > qemu/fsdev/file-op-9p.h:19:10: fatal error: 'sys/vfs.h' file not found
> > > #include <sys/vfs.h>
> > > ???????? ^~~~~~~~~~~
> > >
> > > Am I missing something? (Apart from the include file which is not
> > > present on OS X... Maybe this needs the #ifdefs it had before the split?)
> >
> > It seems commits are not correctly ordered for bisectability :(
> >
> > If you cherry-pick ecd3b89b054, does it build?
>
> No it fails with same error on HEAD as well ever since the above commit.

Now it has built after completely removing build directory. Somehow a 
CONFIG_VIRTIO_9P got set before even after doing make distclean several 
times. Only completetly removing build dir has helped.

Regards,
BALATON Zoltan