[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_tab
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin() |
Date: |
Tue, 29 Jan 2019 09:27:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/29/19 1:08 AM, Wei Yang wrote:
> Function acpi_table_add_builtin() is not used anymore.
>
> Remove the definition and declaration.
>
> Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/acpi/core.c | 6 ------
> include/hw/acpi/acpi.h | 1 -
> 2 files changed, 7 deletions(-)
>
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index d6f0709691..e9b1a85e54 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -305,12 +305,6 @@ out:
>
> static bool acpi_table_builtin = false;
>
> -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
> -{
> - acpi_table_builtin = true;
> - acpi_table_add(opts, errp);
> -}
> -
> unsigned acpi_table_len(void *current)
> {
> struct acpi_table_header *hdr = current - sizeof(hdr->_length);
> diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
> index c20ace0d0b..4a8bbaf1b5 100644
> --- a/include/hw/acpi/acpi.h
> +++ b/include/hw/acpi/acpi.h
> @@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);
> uint8_t *acpi_table_next(uint8_t *current);
> unsigned acpi_table_len(void *current);
> void acpi_table_add(const QemuOpts *opts, Error **errp);
> -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp);
>
> typedef struct AcpiSlicOem AcpiSlicOem;
> struct AcpiSlicOem {
>
- [Qemu-devel] [PATCH 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin, (continued)
- [Qemu-devel] [PATCH 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin, Wei Yang, 2019/01/25
- [Qemu-devel] [PATCH 2/3] hw/acpi: remove unused function acpi_table_add_builtin(), Wei Yang, 2019/01/25
- Re: [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init(), Igor Mammedov, 2019/01/28
- [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/01/28
- [Qemu-devel] [PATCH v2 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin, Wei Yang, 2019/01/28
- [Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_acpi_init(), Wei Yang, 2019/01/28
- [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin(), Wei Yang, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin(),
Philippe Mathieu-Daudé <=
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Philippe Mathieu-Daudé, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Philippe Mathieu-Daudé, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Laurent Vivier, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Michael S. Tsirkin, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/01/29