Re: [Qemu-devel] Building nsis installer - cross compile for Windows

[Daniel P . Berrangé]

On Mon, Jan 28, 2019 at 01:46:57PM +0000, Peter Maydell wrote:
> On Mon, 28 Jan 2019 at 13:34, Adam Baxter <address@hidden> wrote:
> >
> > I'm getting stuck trying to build the NSIS installer for Windows
> >
> >
> > export CFLAGS="-Wno-stringop-truncation"
> > ./configure --python=$(command -v python3)
> > --cross-prefix=x86_64-w64-mingw32- --enable-docs
> > echo 3.99.99 > VERSION
> > make -j`nproc`
> > make -j`nproc` installer
> >
> > results in:
> 
> > File: "/tmp/qemu-nsis\*.bmp" -> no files found.
> > Usage: File [/nonfatal] [/a] ([/r] [/x filespec [...]] filespec [...] |
> >    /oname=outfile one_file_only)
> > Error in script "/drone/src/qemu.nsi" on line 122 -- aborting creation 
> > process
> > make: *** [Makefile:915: qemu-setup-3.99.99.exe] Error 1
> 
> I suspect this is because we've recently removed the
> qemu-icon.bmp but didn't update the NSIS installer script,
> which is now looking for a wildcard that doesn't match anything
> (and isn't trying to install the new .png icon files).
> If you try this on a commit before a8260d3876389eb52 does it
> work?

Opps, I'll cook up a fix that.

> 
> qemu-icon.bmp seems also to still be listed in the LINKS
> in configure which defines what we symlink from the source
> tree to the build tree (and again, the png files are not).

Wierd, I don't understand why we need any of that LINKS stuff in
configure. Not having the png files listed doesn't cause any
obvious problem that I can see. For that matter nor does having
the (now deleted) qemu-icon.bmp seem to cause a failure, as we
silent ignore source tree files that don't exist.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|