Re: [Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

[Philippe Mathieu-Daudé]

On 1/28/19 12:25 PM, Peter Maydell wrote:
> On Mon, 28 Jan 2019 at 11:22, Philippe Mathieu-Daudé <address@hidden> wrote:
>> On 1/27/19 12:37 PM, Marc-André Lureau wrote:
>>> Did you try using G_STATIC_ASSERT* instead?
>> [...]
>>
>> Is there a same plan for QEMU codebase?
> 
> Our version uses _Static_assert where possible, which I think
> will give better error messages than the glib version. There are
> also some corner cases where the glib macros don't work:
> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07090.html
> 
> Broadly, our implementation works and so I don't see much need
> to mess with it, outside of the special case of slirp that's
> trying to cut its ties with QEMU.

OK!

Thanks,

Phil.