[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] target/arm/translate-a64: Don't underdecode
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] target/arm/translate-a64: Don't underdecode SDOT and UDOT |
Date: |
Mon, 28 Jan 2019 12:20:38 +0100 |
On Fri, Jan 25, 2019 at 7:26 PM Peter Maydell <address@hidden> wrote:
>
> In the AdvSIMD scalar x indexed element and vector x indexed element
> encoding group, the SDOT and UDOT instructions are vector only,
> and their opcode is unallocated in the scalar group. Correctly
> UNDEF this unallocated encoding.
>
> Reported-by: Laurent Desnogues <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Laurent Desnogues <address@hidden>
Thanks,
Laurent
> ---
> target/arm/translate-a64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 474d9bfb5f0..30bc2412fc0 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -12641,7 +12641,7 @@ static void disas_simd_indexed(DisasContext *s,
> uint32_t insn)
> break;
> case 0x0e: /* SDOT */
> case 0x1e: /* UDOT */
> - if (size != MO_32 || !dc_isar_feature(aa64_dp, s)) {
> + if (is_scalar || size != MO_32 || !dc_isar_feature(aa64_dp, s)) {
> unallocated_encoding(s);
> return;
> }
> --
> 2.20.1
>
- [Qemu-devel] [PATCH 0/7] target/arm: Fix various underdecodings, Peter Maydell, 2019/01/25
- [Qemu-devel] [PATCH 6/7] target/arm/translate-a64: Don't underdecode FP insns, Peter Maydell, 2019/01/25
- [Qemu-devel] [PATCH 7/7] target/arm/translate-a64: Don't underdecode SDOT and UDOT, Peter Maydell, 2019/01/25
- Re: [Qemu-devel] [PATCH 7/7] target/arm/translate-a64: Don't underdecode SDOT and UDOT,
Laurent Desnogues <=
- [Qemu-devel] [PATCH 5/7] target/arm/translate-a64: Don't underdecode add/sub extended register, Peter Maydell, 2019/01/25
- [Qemu-devel] [PATCH 3/7] target/arm/translate-a64: Don't underdecode SIMD ld/st multiple, Peter Maydell, 2019/01/25
- [Qemu-devel] [PATCH 4/7] target/arm/translate-a64: Don't underdecode SIMD ld/st single, Peter Maydell, 2019/01/25
- [Qemu-devel] [PATCH 1/7] target/arm/translate-a64: Don't underdecode system instructions, Peter Maydell, 2019/01/25
- [Qemu-devel] [PATCH 2/7] target/arm/translate-a64: Don't underdecode PRFM, Peter Maydell, 2019/01/25