[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v4 26/44] kconfig: introduce kconfig files
From: |
Yang Zhong |
Subject: |
Re: [Qemu-devel] [RFC PATCH v4 26/44] kconfig: introduce kconfig files |
Date: |
Fri, 25 Jan 2019 10:18:09 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 24, 2019 at 03:06:01PM +0100, Thomas Huth wrote:
> On 2019-01-23 07:56, Yang Zhong wrote:
> > From: Paolo Bonzini <address@hidden>
> >
> > The Kconfig files were generated mostly with this script:
> >
> > for i in `grep -ho CONFIG_[A-Z0-9_]* default-configs/* | sort -u`; do
> > set fnord `git grep -lw $i -- 'hw/*/Makefile.objs' `
> > shift
> > if test $# = 1; then
> > cat >> $(dirname $1)/Kconfig << EOF
> > config ${i#CONFIG_}
> > bool
> >
> > EOF
> > git add $(dirname $1)/Kconfig
> > else
> > echo $i $*
> > fi
> > done
> > sed -i '$d' hw/*/Kconfig
> > for i in hw/*; do
> > if test -d $i && ! test -f $i/Kconfig; then
> > touch $i/Kconfig
> > git add $i/Kconfig
> > fi
> > done
> >
> > Whenever a symbol is referenced from multiple subdirectories, the
> > script prints the list of directories that reference the symbol.
> > These symbols have to be added manually to the Kconfig files.
> >
> > Kconfig.host and hw/Kconfig were created manually.
> >
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Yang Zhong <address@hidden>
> > ---
> [...]
> > diff --git a/hw/cris/Kconfig b/hw/cris/Kconfig
> > new file mode 100644
> > index 0000000000..c2c26e5150
> > --- /dev/null
> > +++ b/hw/cris/Kconfig
> > @@ -0,0 +1,2 @@
> > +config AXIS
> > + bool
>
> Please also add here:
>
> config ETRAXFS
> bool
>
Yes, i will add this, thanks, Yang.
> > diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
> > new file mode 100644
> > index 0000000000..1a3e8b0e02
> > --- /dev/null
> > +++ b/hw/riscv/Kconfig
> > @@ -0,0 +1,14 @@
> > +config HTIF
> > + bool
> > +
> > +config HART
> > + bool
> > +
> > +config SIFIVE
> > + bool
> > +
> > +config SPIKE
> > + bool
> > +
> > +config RISCV_VIRTIO
> > + bool
>
> Please rename the RISCV_VIRTIO to RISCV_VIRT.
>
> We also additionally need these two here:
>
> config SIFIVE_E
> bool
>
> config SIFIVE_U
> bool
>
Wow, this is my mistake, i omitted this, thanks for reminder!
Regards,
Yang
> Thanks,
> Thomas
- [Qemu-devel] [RFC PATCH v4 21/44] hw/tricore/Makefile.objs: Create CONFIG_* for tricore, (continued)
- [Qemu-devel] [RFC PATCH v4 21/44] hw/tricore/Makefile.objs: Create CONFIG_* for tricore, Yang Zhong, 2019/01/23
- [Qemu-devel] [RFC PATCH v4 22/44] minikconfig: add parser skeleton, Yang Zhong, 2019/01/23
- [Qemu-devel] [RFC PATCH v4 23/44] minikconfig: add AST, Yang Zhong, 2019/01/23
- [Qemu-devel] [RFC PATCH v4 25/44] hw/display: make edid configurable, Yang Zhong, 2019/01/23
- [Qemu-devel] [RFC PATCH v4 24/44] minikconfig: add semantic analysis, Yang Zhong, 2019/01/23
- [Qemu-devel] [RFC PATCH v4 28/44] ide: express dependencies with Kconfig, Yang Zhong, 2019/01/23
- [Qemu-devel] [RFC PATCH v4 27/44] build: switch to Kconfig, Yang Zhong, 2019/01/23
- [Qemu-devel] [RFC PATCH v4 26/44] kconfig: introduce kconfig files, Yang Zhong, 2019/01/23
- [Qemu-devel] [RFC PATCH v4 29/44] hw/pci/Makefile.objs: make pcie configurable, Yang Zhong, 2019/01/23
[Qemu-devel] [RFC PATCH v4 31/44] build: convert sound.mak to Kconfig, Yang Zhong, 2019/01/23
[Qemu-devel] [RFC PATCH v4 30/44] build: convert pci.mak to Kconfig, Yang Zhong, 2019/01/23
[Qemu-devel] [RFC PATCH v4 34/44] bluetooth: express dependencies with Kconfig, Yang Zhong, 2019/01/23
[Qemu-devel] [RFC PATCH v4 32/44] build: convert usb.mak to Kconfig, Yang Zhong, 2019/01/23