Re: [Qemu-devel] [RFC v2 06/38] plugin: add core code

[Alex Bennée]

Emilio G. Cota <address@hidden> writes:

> Some design requirements/goals:

Also this commit breaks bisect-ability:


  15:56:23 address@hidden:~/l/q/qemu.git] (0138e1a5…)|BISECTING 2 + head -n 3 
config.log
  # QEMU configure log Thu Jan 24 15:19:36 GMT 2019
  # Configured with: './configure' '--disable-tools' '--disable-docs' 
'--python=/usr/bin/python3'
  #
  15:56:35 address@hidden:~/l/q/qemu.git] (0138e1a5…)|BISECTING + make
          CHK version_gen.h
    CC      qapi/qapi-visit-core.o
  In file included from /home/alex/lsrc/qemu/qemu.git/include/qom/cpu.h:33:0,
                   from ./trace/control-internal.h:13,
                   from ./trace/control.h:270,
                   from qapi/trace.h:7,
                   from qapi/qapi-visit-core.c:21:
  /home/alex/lsrc/qemu/qemu.git/include/qemu/plugin.h:38:49: error: 
‘qemu_plugin_list’ defined as wrong kind of tag
                                            struct qemu_plugin_list *head)
                                                   ^~~~~~~~~~~~~~~~
  /home/alex/lsrc/qemu/qemu.git/include/qemu/plugin.h:38:49: error: ‘struct 
qemu_plugin_list’ declared inside parameter list will not be visible outside of 
this definition or
  declaration [-Werror]
  /home/alex/lsrc/qemu/qemu.git/include/qemu/plugin.h:44:48: error: 
‘qemu_plugin_list’ defined as wrong kind of tag
   static inline int qemu_plugin_load_list(struct qemu_plugin_list *head)
                                                  ^~~~~~~~~~~~~~~~
  /home/alex/lsrc/qemu/qemu.git/include/qemu/plugin.h:44:48: error: ‘struct 
qemu_plugin_list’ declared inside parameter list will not be visible outside of 
this definition or
  declaration [-Werror]
  cc1: all warnings being treated as errors
  /home/alex/lsrc/qemu/qemu.git/rules.mak:69: recipe for target 
'qapi/qapi-visit-core.o' failed
  make: *** [qapi/qapi-visit-core.o] Error 1

--
Alex Bennée